[AttenuatedTweenProperty] Added a AttenuatedShakeTweenProperty and AttenuatedOscillateTweenProperty#37
Open
jpsarda wants to merge 3 commits intoprime31:masterfrom
Open
Conversation
…AbstractTweenProperty (floats, ints, Vector2, etc…). Added corresponding entries in GoTweenConfig ( shakeFloatProp, intFloatProp, etc…).
…haking, oscillating, and more. Created new folder attenuated in properties Moved and renamed ShakeGenericTweenProperty into attenuated/AttenuatedShakeTweenProperty Created AttenuatedOscillateTweenProperty and all necessary entries in GoTweenConfig
zapdot
force-pushed
the
master
branch
2 times, most recently
from
13a310d to
c7e9971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[edit]
I've pushed another commit to create a more generic AttenuatedTweenProperty that can be used for shaking, but also oscillating, and maybe other things. I tested for oscillateFloatProp, shakeFloatProp, oscillateColorProp and shakeColorProp and it works really well.
original description :
Added corresponding entries in GoTweenConfig ( shakeFloatProp, intFloatProp, etc…).
This is a quite elegant way to add a lot of shake options with only one new tween property class. I have the feeling that referencing a tween property inside another tween property opens the way to a new range of powerful tween properties, but not sure yet exactly how this can be exploited and for what precise goal.
Note that I've tested only the shakeFloatProp(...) method but I don't see why other methods wouldn't work.
Hope you accept this, because for example in a 2D engine like Futile, we can't use the current shake tween property that request a Transform for the target.